From 6f6fc8d80eb07c4a64145c8f8fb5b8939afcafed Mon Sep 17 00:00:00 2001 From: Alex Krolick Date: Tue, 1 Jan 2019 19:24:46 -0800 Subject: [PATCH] clarify mountNode with comments This is still a bit opaque but it's difficult to fix with the current way CodeEditor works: - long-term CodeEditor.js could take a node reference instead of defining mountNode internally - could also use document.createElement to define the target in the code, but this could be mislead people to think this is required instead of using an existing reference see #1017, #1018, #1019 --- content/home/examples/a-component-using-external-plugins.js | 2 ++ content/home/examples/a-simple-component.js | 2 ++ content/home/examples/a-stateful-component.js | 2 ++ content/home/examples/an-application.js | 2 ++ 4 files changed, 8 insertions(+) diff --git a/content/home/examples/a-component-using-external-plugins.js b/content/home/examples/a-component-using-external-plugins.js index 48eac0b62ed..25ad6f55563 100644 --- a/content/home/examples/a-component-using-external-plugins.js +++ b/content/home/examples/a-component-using-external-plugins.js @@ -36,4 +36,6 @@ class MarkdownEditor extends React.Component { } } +// let mountNode = document.querySelector('#markdown') + ReactDOM.render(, mountNode); \ No newline at end of file diff --git a/content/home/examples/a-simple-component.js b/content/home/examples/a-simple-component.js index 3efa50193f0..9849a573eb4 100644 --- a/content/home/examples/a-simple-component.js +++ b/content/home/examples/a-simple-component.js @@ -8,6 +8,8 @@ class HelloMessage extends React.Component { } } +// let mountNode = document.querySelector('#message') + ReactDOM.render( , mountNode diff --git a/content/home/examples/a-stateful-component.js b/content/home/examples/a-stateful-component.js index 7414fd6ee2a..dba6de4fecc 100644 --- a/content/home/examples/a-stateful-component.js +++ b/content/home/examples/a-stateful-component.js @@ -27,4 +27,6 @@ class Timer extends React.Component { } } +// let mountNode = document.querySelector('#timer') + ReactDOM.render(, mountNode); \ No newline at end of file diff --git a/content/home/examples/an-application.js b/content/home/examples/an-application.js index 4fe8988ca90..3f43373ff71 100644 --- a/content/home/examples/an-application.js +++ b/content/home/examples/an-application.js @@ -60,4 +60,6 @@ class TodoList extends React.Component { } } +// let mountNode = document.querySelector('#app') + ReactDOM.render(, mountNode);