Skip to content

Conversation

@koba04
Copy link
Member

@koba04 koba04 commented Aug 17, 2020

As the blog mentioned, React has stopped event pooling, and the SyntheticEvent#persist mthod does nothing in v17, so I remove the description from the documentation.

https://reactjs.org/blog/2020/08/10/react-v17-rc.html#no-event-pooling

v17 is still in RC, so this PR might have to be merged after releasing v17 stable.

Does React have a plan to deprecate and remove the SyntheticEvent#persist method in the future??

@gaearon
Copy link
Member

gaearon commented Aug 17, 2020

There's a link in _redirects that links to this section. I think we need to add a separate page (unlisted) for this warning now.

@koba04
Copy link
Member Author

koba04 commented Aug 17, 2020

@gaearon
Thank you. I've added a page for the legacy event pooling and updated the redirect link.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it's still there so it should be in the API reference. Just needs to note it doesn't do anything.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaearon
Thank you. I've added the note as another note at 89a9c29.

@reactjs-bot
Copy link

reactjs-bot commented Oct 15, 2020

Deploy preview for reactjs ready!

Built with commit 1446ab4

https://deploy-preview-3207--reactjs.netlify.app

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit 3b3c1737c3fffd7cde195f22635975c7d1beff5b

https://deploy-preview-3207--reactjs.netlify.app

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit fab63bb37611d88cffc5274e6dd269a859b160fc

https://deploy-preview-3207--reactjs.netlify.app

@gaearon gaearon mentioned this pull request Oct 20, 2020
3 tasks
@vercel
Copy link

vercel bot commented Oct 22, 2020

@koba04 is attempting to deploy a commit to the Facebook Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@koba04
Copy link
Member Author

koba04 commented Oct 22, 2020

React 17 has been released, so this PR is ready for review.

@gaearon
Copy link
Member

gaearon commented Oct 22, 2020

Can you please rebase and then also mirror changes in vercel.json?

@vercel
Copy link

vercel bot commented Oct 22, 2020

Deployment failed with the following error:

The most recent charge for your active payment method has failed. Please update it here: https://vercel.com/teams/fbopensource/settings/billing

@koba04 koba04 force-pushed the remove-event-pooling-and-persist-method branch from 4772c9a to 2942b2d Compare October 23, 2020 01:02
@koba04
Copy link
Member Author

koba04 commented Oct 23, 2020

I've rebased and modified a redirect link in vercel.json

@gaearon gaearon merged commit 64d067f into reactjs:master Oct 23, 2020
@koba04 koba04 deleted the remove-event-pooling-and-persist-method branch October 24, 2020 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants