-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Remove event pooling and SyntheticEvent#persist from documents #3207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove event pooling and SyntheticEvent#persist from documents #3207
Conversation
|
There's a link in |
|
@gaearon |
content/docs/reference-events.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically it's still there so it should be in the API reference. Just needs to note it doesn't do anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Deploy preview for reactjs ready! Built with commit 1446ab4 |
|
Deploy preview for reactjs ready! Built with commit 3b3c1737c3fffd7cde195f22635975c7d1beff5b |
|
Deploy preview for reactjs ready! Built with commit fab63bb37611d88cffc5274e6dd269a859b160fc |
|
@koba04 is attempting to deploy a commit to the Facebook Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
React 17 has been released, so this PR is ready for review. |
|
Can you please rebase and then also mirror changes in |
|
Deployment failed with the following error: |
Syntheticevent#event exists in v17, but it does nothing at the version
4772c9a to
2942b2d
Compare
|
I've rebased and modified a redirect link in |

As the blog mentioned, React has stopped event pooling, and the
SyntheticEvent#persistmthod does nothing in v17, so I remove the description from the documentation.https://reactjs.org/blog/2020/08/10/react-v17-rc.html#no-event-pooling
v17 is still in RC, so this PR might have to be merged after releasing v17 stable.Does React have a plan to deprecate and remove the
SyntheticEvent#persistmethod in the future??