Skip to content

Conversation

@rravishankar
Copy link

https://reactjs.org/docs/handling-events.html

Handling Events -> Passing Arguments to Event Handlers

Since the event argument may not always be second, but actually is always the last, this change proposes to make it clear.

https://reactjs.org/docs/handling-events.html

Handling Events -> Passing Arguments to Event Handlers 

Since the event argument may not always be second, but actually is always the last, this change proposes to make it clear.
@facebook-github-bot
Copy link
Collaborator

Hi @rravishankar!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@github-actions
Copy link

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@eps1lon
Copy link
Member

eps1lon commented Jun 28, 2022

Since the event argument may not always be second, but actually is always the last, this change proposes to make it clear.

It is in this example it is second though so better be explicit about it. Could you clarify when it would not be the second argument?

@rravishankar
Copy link
Author

rravishankar commented Jun 28, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants