New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added documentation for passing arguments to event handlers #81

Merged
merged 4 commits into from Oct 10, 2017

Conversation

Projects
None yet
7 participants
@sw-yx
Contributor

sw-yx commented Oct 8, 2017

hi, addressing issue #75 !

image

@reactjs-bot

This comment has been minimized.

Show comment
Hide comment
@reactjs-bot

reactjs-bot commented Oct 8, 2017

Deploy preview ready!

Built with commit 7f8d084

https://deploy-preview-81--reactjs.netlify.com

@bvaughn

Please remove package-lock.json from this PR 😄

@sw-yx

This comment has been minimized.

Show comment
Hide comment
@sw-yx

sw-yx Oct 9, 2017

Contributor

sorry bout that. package-lock never used to matter when i was just working on my little repos. removed and recommitted.

Contributor

sw-yx commented Oct 9, 2017

sorry bout that. package-lock never used to matter when i was just working on my little repos. removed and recommitted.

@sw-yx

This comment has been minimized.

Show comment
Hide comment
@sw-yx

sw-yx Oct 10, 2017

Contributor

Pushed and awaiting your review. sorry for the original problematic line (i'm still not super comfortable when it comes to questions of context)

Contributor

sw-yx commented Oct 10, 2017

Pushed and awaiting your review. sorry for the original problematic line (i'm still not super comfortable when it comes to questions of context)

@bvaughn

Thanks a bunch for the changes 😄

@bvaughn bvaughn merged commit e9a67af into reactjs:master Oct 10, 2017

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Oct 10, 2017

Member

Tweaked in db1262d.

"Param" is not explained, and people might confuse it with some React term. "Parameter" is more explicit.

Also added reference links.

Finally, these two lines weren't equivalent, and people would likely ask how to get access to the event. So I made them consistent.

Thanks for working on this change!

Member

gaearon commented Oct 10, 2017

Tweaked in db1262d.

"Param" is not explained, and people might confuse it with some React term. "Parameter" is more explicit.

Also added reference links.

Finally, these two lines weren't equivalent, and people would likely ask how to get access to the event. So I made them consistent.

Thanks for working on this change!

@bvaughn

This comment has been minimized.

Show comment
Hide comment
@bvaughn

bvaughn Oct 10, 2017

Contributor

Nice changes Dan. Thanks for adding to the section.

Contributor

bvaughn commented Oct 10, 2017

Nice changes Dan. Thanks for adding to the section.

@sw-yx sw-yx deleted the sw-yx:documentArgsIssue75 branch Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment