Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create TRANSLATION.md #5

Merged
merged 8 commits into from Feb 12, 2019

Conversation

@ApolllonDev
Copy link
Member

commented Feb 12, 2019

@klymenkoo @ithompson4
This file contains translations of terms.
Please review.

@ApolllonDev ApolllonDev self-assigned this Feb 12, 2019

@ApolllonDev ApolllonDev requested review from ithompson4 and klymenkoo Feb 12, 2019

@ApolllonDev ApolllonDev referenced this pull request Feb 12, 2019
68 of 88 tasks complete
@klymenkoo
Copy link
Contributor

left a comment

Good job @ApolllonDev!
Just a couple of small changes, and it's good to go.

TRANSLATION.md Outdated Show resolved Hide resolved
TRANSLATION.md Outdated Show resolved Hide resolved
TRANSLATION.md Outdated Show resolved Hide resolved
TRANSLATION.md Outdated Show resolved Hide resolved
TRANSLATION.md Outdated Show resolved Hide resolved
@klymenkoo
Copy link
Contributor

left a comment

1 small change, and it'll be shipped 🚢

TRANSLATION.md Outdated Show resolved Hide resolved
TRANSLATION.md Outdated Show resolved Hide resolved
@westanvv

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

Offer to add: valid - валідний

@ApolllonDev

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2019

@klymenkoo
Should I add rendered markup translation as інтерфейс користувача?

@klymenkoo

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

@klymenkoo
Should I add rendered markup translation as інтерфейс користувача?

I would translate Rendered markup as Відрендерена розмітка.
UI is інтерфейс користувача.

Those are different terms.

@klymenkoo

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

@ApolllonDev looks good! thank you for your contribution 👏

@klymenkoo klymenkoo merged commit 2697e27 into reactjs:master Feb 12, 2019

@ApolllonDev ApolllonDev deleted the ApolllonDev:uk-translation-md branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.