From 20908b3563daec70ac964ed9d11482f4f198eab1 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Sun, 16 Oct 2022 16:45:48 +0100 Subject: [PATCH] New Architecture - Remove the extra steps required to copy .so files (#3356) --- docs/new-architecture-app-intro.md | 29 +---------------------------- 1 file changed, 1 insertion(+), 28 deletions(-) diff --git a/docs/new-architecture-app-intro.md b/docs/new-architecture-app-intro.md index a8699f6a995..6cf7f6eb551 100644 --- a/docs/new-architecture-app-intro.md +++ b/docs/new-architecture-app-intro.md @@ -193,9 +193,7 @@ dependencies { - debugImplementation files(hermesPath + "hermes-debug.aar") - releaseImplementation files(hermesPath + "hermes-release.aar") + //noinspection GradleDynamicVersion -+ implementation("com.facebook.react:hermes-engine:+") { // From node_modules -+ exclude group:'com.facebook.fbjni' -+ } ++ implementation("com.facebook.react:hermes-engine:+") // From node_modules } } @@ -250,31 +248,6 @@ android { } ``` -In the same `build.gradle` file, inside the same `android{}` also add the following section: - -```groovy -android { - // ... - - def reactAndroidProjectDir = project(':ReactAndroid').projectDir - def packageReactNdkLibs = tasks.register("packageReactNdkLibs", Copy) { - dependsOn(":ReactAndroid:packageReactNdkLibsForBuck") - dependsOn("generateCodegenArtifactsFromSchema") - from("$reactAndroidProjectDir/src/main/jni/prebuilt/lib") - into("$buildDir/react-ndk/exported") - } - - afterEvaluate { - preBuild.dependsOn(packageReactNdkLibs) - } - - packagingOptions { - pickFirst '**/libhermes.so' - pickFirst '**/libjsc.so' - } -} -``` - Finally, you need to create two files that are required to build the native code correctly: - A CMake file with the compilation instructions (similar to a `build.gradle` for Android/Java)