From 3fafbe6680fc8bd4b875f9da2c3c4772b526e0c5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dariusz=20J=C4=99drzejczyk?=
 <dariusz.jedrzejczyk@broadcom.com>
Date: Wed, 20 Mar 2024 21:20:11 +0100
Subject: [PATCH] [build] Rename and refactor nightly.yml -> full.yml (#3768)

Simplifying the nightly.yml workflow to reflect snapshot.yml workflow
file. The file is renamed to full.yml.
---
 .github/workflows/full.yml      | 35 +++++++++++++++++++++++++
 .github/workflows/nightly.yml   | 45 ---------------------------------
 .github/workflows/snapshots.yml |  2 +-
 3 files changed, 36 insertions(+), 46 deletions(-)
 create mode 100644 .github/workflows/full.yml
 delete mode 100644 .github/workflows/nightly.yml

diff --git a/.github/workflows/full.yml b/.github/workflows/full.yml
new file mode 100644
index 0000000000..117f0b0a21
--- /dev/null
+++ b/.github/workflows/full.yml
@@ -0,0 +1,35 @@
+name: Full Check
+
+on:
+  schedule:
+    - cron: "0 14 * * 0"
+permissions: read-all
+jobs:
+  run-tests:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        branch: [ 3.5.x, main ]
+        test-type:
+          - type: core
+            arguments: ":reactor-core:test --no-daemon"
+          - type: other
+            arguments: "check -x :reactor-core:test -x spotlessCheck -x :reactor-core:jcstress --no-daemon"
+          - type: jcstress
+            arguments: ":reactor-core:jcstress -Pjcstress.mode=default --no-daemon"
+    name: Test on ${{ matrix.branch }} - ${{ matrix.test-type.type }} tests
+    steps:
+      - name: Checkout Repository
+        uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # tag=v4
+        with:
+          ref: ${{ matrix.branch }}
+      - name: Setup Java 8
+        uses: actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9 # tag=v3
+        with:
+          distribution: 'temurin'
+          java-version: 8
+      - name: Run Gradle Tests
+        uses: gradle/actions/setup-gradle@417ae3ccd767c252f5661f1ace9f835f9654f2b5 # tag=v3
+        with:
+          arguments: ${{ matrix.test-type.arguments }}
\ No newline at end of file
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
deleted file mode 100644
index 81dc68d9c8..0000000000
--- a/.github/workflows/nightly.yml
+++ /dev/null
@@ -1,45 +0,0 @@
-name: Nightly Check
-
-on:
-  schedule:
-    - cron: "0 14 * * 0"
-permissions: read-all
-jobs:
-  core:
-    name: core fast tests
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        branch: [ 3.5.x, main ]
-    steps:
-      - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # tag=v4
-        with:
-          ref: ${{ matrix.branch }}
-      - uses: actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9 # tag=v3
-        with:
-          distribution: 'temurin'
-          java-version: 8
-      - uses: gradle/actions/setup-gradle@417ae3ccd767c252f5661f1ace9f835f9654f2b5 # tag=v3
-        name: gradle
-        with:
-          arguments: :reactor-core:test --no-daemon -DuseSnapshotMicrometerVersion=true
-  other:
-    name: other tests
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        branch: [ 3.5.x, main ]
-    steps:
-      - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # tag=v4
-        with:
-          ref: ${{ matrix.branch }}
-      - uses: actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9 # tag=v3
-        with:
-          distribution: 'temurin'
-          java-version: 8
-      - uses: gradle/actions/setup-gradle@417ae3ccd767c252f5661f1ace9f835f9654f2b5 # tag=v3
-        name: other tests
-        with:
-          arguments: check -x :reactor-core:test -x spotlessCheck --no-daemon -DuseSnapshotMicrometerVersion=true -Pjcstress.mode=default
\ No newline at end of file
diff --git a/.github/workflows/snapshots.yml b/.github/workflows/snapshots.yml
index 9e818183c1..85b4e03903 100644
--- a/.github/workflows/snapshots.yml
+++ b/.github/workflows/snapshots.yml
@@ -22,7 +22,7 @@ jobs:
         uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # tag=v4
         with:
           ref: ${{ matrix.branch }}
-      - name: Setup Java8
+      - name: Setup Java 8
         uses: actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9 # tag=v3
         with:
           distribution: 'temurin'