Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Kotlin support (moved to reactor-kotlin) #1691

Merged
merged 2 commits into from May 6, 2019
Merged

Conversation

bsideup
Copy link
Contributor

@bsideup bsideup commented May 6, 2019

The build will fail due to the compatibility check

@bsideup bsideup added warn/api-change Breaking change with compilation errors area/kotlin This belongs to the kotlin theme labels May 6, 2019
@bsideup bsideup added this to the 3.3.0.M1 milestone May 6, 2019
@simonbasle
Copy link
Member

@bsideup the build japicmp task has an classExclude configuration option that can take a String[] of fully-qualified class names to exclude from the comparison. not sure how valid that option is for kotlin code though, since the extensions are not classes... maybe building locally and looking at the full japicmp report will help?

@bsideup
Copy link
Contributor Author

bsideup commented May 6, 2019

@simonbasle good idea! Done

@codecov-io
Copy link

codecov-io commented May 6, 2019

Codecov Report

Merging #1691 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1691      +/-   ##
============================================
+ Coverage     84.35%   84.39%   +0.03%     
+ Complexity     3931     3930       -1     
============================================
  Files           362      357       -5     
  Lines         30048    29995      -53     
  Branches       5590     5589       -1     
============================================
- Hits          25346    25313      -33     
+ Misses         3085     3073      -12     
+ Partials       1617     1609       -8
Impacted Files Coverage Δ Complexity Δ
...src/main/java/reactor/core/publisher/MonoNext.java 80% <0%> (-7.5%) 2% <0%> (ø)
...va/reactor/core/publisher/MonoCompletionStage.java 86.66% <0%> (-6.67%) 10% <0%> (-1%)
.../main/java/reactor/core/publisher/FluxFlatMap.java 94.4% <0%> (-0.39%) 13% <0%> (ø)
...ain/java/reactor/core/publisher/FluxConcatMap.java 90.14% <0%> (-0.29%) 7% <0%> (ø)
...rc/main/java/reactor/core/publisher/Operators.java 80.56% <0%> (+0.14%) 125% <0%> (ø) ⬇️
...c/main/java/reactor/core/publisher/FluxReplay.java 84.31% <0%> (+0.15%) 25% <0%> (ø) ⬇️
...c/main/java/reactor/core/publisher/FluxExpand.java 95.06% <0%> (+0.44%) 3% <0%> (ø) ⬇️
...eactor/core/publisher/ParallelMergeSequential.java 80.31% <0%> (+0.51%) 7% <0%> (ø) ⬇️
...ava/reactor/core/publisher/EventLoopProcessor.java 80.82% <0%> (+0.51%) 53% <0%> (+1%) ⬆️
...in/java/reactor/core/publisher/TopicProcessor.java 74.85% <0%> (+0.59%) 16% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8a2dac...de8a67e. Read the comment docs.

@smaldini smaldini merged commit 2d285f5 into master May 6, 2019
@smaldini smaldini deleted the remove_kotlin branch May 6, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kotlin This belongs to the kotlin theme warn/api-change Breaking change with compilation errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants