New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in javadoc of multiple files and README.md #305

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@not-for-me
Copy link
Contributor

not-for-me commented Dec 15, 2016

  • correct typos in javadoc
  • modify the link of reactor-core javadoc in README.md
Fix typos in javadoc of multiple files and README.md
- correct typos in javadoc
- modify the link of reactor-core javadoc in README.md
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 15, 2016

Current coverage is 60.71% (diff: 100%)

No coverage report found for master at 4b7b97b.

Powered by Codecov. Last update 4b7b97b...285a470

@not-for-me

This comment has been minimized.

Copy link
Contributor

not-for-me commented Dec 15, 2016

I found more broken links in README.md.
After closing this pr and I am going to submit another pr.

@not-for-me not-for-me closed this Dec 15, 2016

@simonbasle

This comment has been minimized.

Copy link
Contributor

simonbasle commented Dec 15, 2016

hey @not-for-me ! thanks for looking out for typos :) I usually create a dedicated branch in my forks for my PRs, because then you can use that to logically group multiple commits. For example here you could have fixed the other typos in a second commit, pushed it on the same branch and it would have been part of this PR ;)
I'll go look at #306 anyway, just wanted to let you know about this "tip".

@not-for-me

This comment has been minimized.

Copy link
Contributor

not-for-me commented Dec 15, 2016

@simonbasle Thanks for your kindness :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment