From f9ad61722414910136f27c2a836ff09b3c391f82 Mon Sep 17 00:00:00 2001 From: Violeta Georgieva Date: Fri, 24 Mar 2023 11:30:17 +0200 Subject: [PATCH] Add DEBUG log for ServerTransport#disposeNow (#2742) Extend the comments for channel#close invocation --- .../reactor/netty/transport/ServerTransport.java | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/reactor-netty-core/src/main/java/reactor/netty/transport/ServerTransport.java b/reactor-netty-core/src/main/java/reactor/netty/transport/ServerTransport.java index 70f2147b0c..f52e5b3cac 100644 --- a/reactor-netty-core/src/main/java/reactor/netty/transport/ServerTransport.java +++ b/reactor-netty-core/src/main/java/reactor/netty/transport/ServerTransport.java @@ -530,6 +530,9 @@ public final void dispose() { @Override @SuppressWarnings("FutureReturnValueIgnored") public void disposeNow(Duration timeout) { + if (log.isDebugEnabled()) { + log.debug(format(channel(), "Server is about to be disposed with timeout: {}"), timeout); + } if (isDisposed()) { return; } @@ -554,12 +557,17 @@ public void disposeNow(Duration timeout) { Channel channel = entry.getKey(); List> monos = entry.getValue(); if (monos.isEmpty()) { - //"FutureReturnValueIgnored" this is deliberate + // At this point there are no running requests for this channel + // "FutureReturnValueIgnored" this is deliberate channel.close(); } else { - //"FutureReturnValueIgnored" this is deliberate - terminateSignals = Mono.when(monos).doFinally(sig -> channel.close()).and(terminateSignals); + terminateSignals = + Mono.when(monos) + // At this point there are no running requests for this channel + // "FutureReturnValueIgnored" this is deliberate + .doFinally(sig -> channel.close()) + .and(terminateSignals); } } }