Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClient doesn't use secure scheme when rewriting relative GETs #109

Closed
simonbasle opened this issue Jun 21, 2017 · 0 comments
Closed

HttpClient doesn't use secure scheme when rewriting relative GETs #109

simonbasle opened this issue Jun 21, 2017 · 0 comments
Assignees
@simonbasle
Labels
type/bug A general bug
Milestone
0.7.0.M1

Comments

@simonbasle
Copy link
Member

Attempting to make a self-signed HttpServer and HttpClient dialog through SSL, this leads to unstable state and the server will loop forever, never managing to negotiate the SSL handshake.

At the root cause is HttpClientOptions.formatSchemeAndHost, which doesn't use the HTTPS (or WSS) scheme even though the SslContext is set.
@simonbasle simonbasle added this to the 0.7.0.M1 milestone Jun 21, 2017
@simonbasle simonbasle self-assigned this Jun 21, 2017
simonbasle added a commit that referenced this issue Jun 21, 2017
@simonbasle
fix #109 Make HttpClient SSL work on relative GET
ce6cf2b 
This commit fixes HttpClient not correctly working with SSL activated
when performing a request (eg. get) on a relative url/path.

This was due to HttpClientOptions.formatSchemeAndHostRelative not taking
the SslContext configuration into account when creating a full URL for
such a request, resulting in HTTP requests being performed on a HTTPS
connection.
@simonbasle simonbasle added the type/bug A general bug label Jun 21, 2017
utwyko pushed a commit to utwyko/reactor-netty that referenced this issue Jul 6, 2017
@simonbasle
fix reactor#109 Make HttpClient SSL work on relative GET
1e8d051 
This commit fixes HttpClient not correctly working with SSL activated
when performing a request (eg. get) on a relative url/path.

This was due to HttpClientOptions.formatSchemeAndHostRelative not taking
the SslContext configuration into account when creating a full URL for
such a request, resulting in HTTP requests being performed on a HTTPS
connection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonbasle simonbasle

Labels
type/bug A general bug
Projects
None yet
Milestone
0.7.0.M1
Development

No branches or pull requests
1 participant
@simonbasle