Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not cache Meter builders #1974

Merged
merged 2 commits into from Jan 10, 2022
Merged

Do not cache Meter builders #1974

merged 2 commits into from Jan 10, 2022

Conversation

violetagg
Copy link
Member

Meter builders are mutable and not thread safe.

@violetagg
Do not cache Meter builders
b47cd15 
Meter builders are mutable and not thread safe.
@violetagg violetagg added this to the 1.0.15 milestone Jan 10, 2022
@violetagg violetagg requested a review from a team January 10, 2022 11:06
simonbasle
simonbasle approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very small nitpick, approving nonetheless, that's a good catch 👍
has there been any reports of bad metrics that could be due to this ?

reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java Outdated Show resolved Hide resolved
reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java Outdated Show resolved Hide resolved
reactor-netty-core/src/main/java/reactor/netty/channel/MicrometerChannelMetricsRecorder.java Outdated Show resolved Hide resolved
@violetagg
Copy link
Member Author

very small nitpick, approving nonetheless, that's a good catch 👍
has there been any reports of bad metrics that could be due to this ?

No, I don't think we had anything related to these meters.

@violetagg
Copy link
Member Author

@simonbasle Thanks for the review!

@violetagg violetagg merged commit 3d5f96e into main Jan 10, 2022
@violetagg violetagg deleted the meter-builders branch January 10, 2022 12:52
@violetagg violetagg added the type/enhancement A general enhancement label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbasle simonbasle simonbasle approved these changes

Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
1.0.15
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@violetagg @simonbasle