Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Antora only when publishing #3162

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

pderop
Copy link
Contributor

@pderop pderop commented Apr 16, 2024

This PR is an attempt to accelerate the build when using JDK17, and when you don't need to generate antora docs.

typically, it should accelerate commands like ./gradlew clean build

to build the documentation:

  • ./gradlew antora (docs is generated to docs/build/site/ as before)
  • or ./gradlew publishToMavenLocal

modifications:

  • the docs/build.gradle is not making the build depending on antora anymore
  • removed the following unnecessary declaration in reactor-netty/build.gradle, which comes from spring-pulsar, we don't need this, and it forces the docsZip to be created when building or assembling the project:
artifacts {
	archives docsZip
}

Fixes #3157

@pderop pderop added the type/chore A task not related to code (build, formatting, process, ...) label Apr 16, 2024
@pderop pderop added this to the 1.2.0-M2 milestone Apr 16, 2024
@pderop pderop self-assigned this Apr 16, 2024
@pderop pderop requested a review from violetagg April 16, 2024 17:05
@pderop pderop merged commit 21bf1d6 into reactor:main Apr 16, 2024
14 checks passed
@pderop pderop deleted the build-antora-only-when-publishing branch April 16, 2024 19:09
pderop added a commit that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore A task not related to code (build, formatting, process, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build should not depend on doc:antora
2 participants