Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Content-Length:0 release the Object scheduled for writing #554

Merged
merged 1 commit into from Dec 19, 2018

Conversation

violetagg
Copy link
Member

When Connection:close invoke first cleanup so that the cancelation
is propagated to the publishers and then close the connection

@violetagg violetagg added this to the 0.7.13.RELEASE milestone Dec 14, 2018
When Connection:close invoke first cleanup so that the cancelation
is propagated to the publishers and then close the connection
@codecov-io
Copy link

codecov-io commented Dec 19, 2018

Codecov Report

Merging #554 into 0.7.x will decrease coverage by 0.15%.
The diff coverage is 95.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##              0.7.x     #554      +/-   ##
============================================
- Coverage     68.21%   68.06%   -0.16%     
- Complexity     1088     1089       +1     
============================================
  Files            73       73              
  Lines          4735     4750      +15     
  Branches        676      677       +1     
============================================
+ Hits           3230     3233       +3     
- Misses         1120     1128       +8     
- Partials        385      389       +4
Impacted Files Coverage Δ Complexity Δ
.../ipc/netty/http/server/HttpServerWSOperations.java 60% <ø> (ø) 15 <0> (ø) ⬇️
.../ipc/netty/http/client/HttpClientWSOperations.java 60.21% <ø> (ø) 18 <0> (ø) ⬇️
src/main/java/reactor/ipc/netty/NettyOutbound.java 80.28% <100%> (+0.28%) 30 <1> (+1) ⬆️
...actor/ipc/netty/http/server/HttpServerHandler.java 79.45% <100%> (+0.14%) 43 <0> (ø) ⬇️
src/main/java/reactor/ipc/netty/FutureMono.java 72.86% <100%> (+1.32%) 11 <4> (+3) ⬆️
src/main/java/reactor/ipc/netty/ReactorNetty.java 77.93% <87.5%> (+0.39%) 23 <0> (ø) ⬇️
.../ipc/netty/channel/PooledClientContextHandler.java 54.31% <0%> (-3.45%) 22% <0%> (ø)
...or/ipc/netty/http/client/HttpClientOperations.java 58.11% <0%> (-1.46%) 81% <0%> (-2%)
...a/reactor/ipc/netty/channel/ChannelOperations.java 82.67% <0%> (-0.79%) 47% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26f97df...b7e9848. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants