Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ReactorRabbitMQ -> RabbitFlux ? #4

Closed
smaldini opened this issue Nov 22, 2017 · 9 comments
Closed

Rename ReactorRabbitMQ -> RabbitFlux ? #4

smaldini opened this issue Nov 22, 2017 · 9 comments
Labels
for/stackoverflow Questions are best asked on SO or Gitter

Comments

@smaldini
Copy link
Contributor

As title says

@smaldini smaldini added the for/stackoverflow Questions are best asked on SO or Gitter label Nov 22, 2017
@wxlund
Copy link

wxlund commented Feb 23, 2018

Is there any reason not to put the spring label on as well?

Spring-webflux
Spring-rabbitflux

I hope it looks side by side like we’re doing with mongo driver, web, etc.

@acogoluegnes
Copy link
Contributor

@wxlund Reactor RabbitMQ is based on Reactor Core and RabbitMQ Java client, it does not depend at all on Spring.

@wxlund
Copy link

wxlund commented Feb 27, 2018 via email

@acogoluegnes
Copy link
Contributor

@wxlund Not that I'm aware of. Right now, the closest would be to use Spring Integration 5.0 with the reactive support. /cc @garyrussell @artembilan.

@artembilan
Copy link

@wxlund,

Contribution is welcome, but I'm not sure that it is going to be a separate module. Maybe simple pair of Spring-wrappers around Sender and Receiver in the existing spring-rabbit is enough...

@artembilan
Copy link

And right: Spring Integration 5.0 can already be used with this Reactive components. I presented last SpringOne possible approach with reactor-kafka:

https://github.com/artembilan/spring-integration-s1p2017/blob/master/src/test/java/org/springoneplatform2017/integration/kafka/SpringIntegrationS1p2017KafkaTests.java#L82-L95

@acogoluegnes
Copy link
Contributor

@smaldini No objections to that. Is it a common convention between Reactor-based extension?

@acogoluegnes
Copy link
Contributor

Per conversation with @simonbasle, we'll stick to the current name.

@acogoluegnes
Copy link
Contributor

As per discussion with @simonbasle and @smaldini, addressing this one for consistency with other static helpers in the Reactor ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for/stackoverflow Questions are best asked on SO or Gitter
Projects
None yet
Development

No branches or pull requests

4 participants