Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netstat localize #1657

Merged
merged 1 commit into from Jun 20, 2019

Conversation

@milawynsrealm
Copy link
Contributor

milawynsrealm commented Jun 15, 2019

Purpose

Localize the netstat utility so it can be localized into different languages. Also, the File Description of the program has been to changed to better describe the purpose of the utility and also because one day we'll support TCP/IPv6.

JIRA issue: CORE-16119

Proposed changes

Describe what you propose to change/add/fix with this pull request.

  • Localize the utility to support multiple languages.
  • Update the File Description to better reflect the purpose of the utility.
@BenNottelling

This comment has been minimized.

Copy link
Contributor

BenNottelling commented Jun 15, 2019

Commit history is a bit messy, can you clean that up?

@tkreuzer tkreuzer added this to New PRs in ReactOS PRs Jun 16, 2019
@HBelusca HBelusca self-assigned this Jun 17, 2019
@HBelusca HBelusca force-pushed the milawynsrealm:netstat_localize branch 2 times, most recently from 388b3e8 to c079db7 Jun 17, 2019
HBelusca added a commit to milawynsrealm/reactos that referenced this pull request Jun 17, 2019
…eactos#1657)

CORE-16119

Also, change its resource file description to reflect that the utility isn't just for TCPv4.
@HBelusca HBelusca force-pushed the milawynsrealm:netstat_localize branch from c079db7 to bd3c852 Jun 20, 2019
@HBelusca HBelusca merged commit bd3c852 into reactos:master Jun 20, 2019
0 of 4 checks passed
0 of 4 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
ReactOS PRs automation moved this from New PRs to Done Jun 20, 2019
…1657)

CORE-16119

Also, change its resource file description to reflect that the utility isn't just for TCPv4.
@SergeGautherie SergeGautherie mentioned this pull request Jul 7, 2019
0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
ReactOS PRs
  
Done
3 participants
You can’t perform that action at this time.