Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MC] Fix build of message text files for latest VS version #652

Merged
merged 1 commit into from Jun 30, 2018
Merged

[MC] Fix build of message text files for latest VS version #652

merged 1 commit into from Jun 30, 2018

Conversation

tkreuzer
Copy link
Contributor

  • Latest VS does not like half translated files
  • errcodes.mc is duplicated in kernel32
  • It would probably be better to separate each language into it's own file, but we need a build mechanism for that

@tkreuzer
[MC] Fix build of message text files for latest VS version
789db22 
* Latest VS does not like half translated files :/
* errcodes.mc is duplicated in kernel32
* It would probably be better to separate each language into it's own file, but we need a build mechanism for that
HBelusca
HBelusca approved these changes Jun 30, 2018
View reviewed changes
Copy link
Contributor

@HBelusca HBelusca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tkreuzer tkreuzer merged commit c73c4f0 into reactos:master Jun 30, 2018
@HBelusca
Copy link
Contributor

Ok now we get the problem of, because kernel32 et al. are now bigger, there are relocation problems, see the latest failures in https://build.reactos.org/builders/Test%20KVM (logs give error 0xc0000269 due to relocation of kernel32.dll).

@tkreuzer tkreuzer deleted the pr/Fix_mc_files_for_latest_VS branch August 18, 2018 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HBelusca HBelusca HBelusca approved these changes

@AmineKhaldi AmineKhaldi Awaiting requested review from AmineKhaldi

@learn-more learn-more Awaiting requested review from learn-more

@gigaherz gigaherz Awaiting requested review from gigaherz

@HeisSpiter HeisSpiter Awaiting requested review from HeisSpiter

@ColinFinck ColinFinck Awaiting requested review from ColinFinck

@sanchaez sanchaez Awaiting requested review from sanchaez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tkreuzer @HBelusca