Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting when spawning child process fails #73

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
3 participants
@clue
Copy link
Member

clue commented Feb 13, 2019

Suppress PHP warnings on error and report any error message as part of
exception messages as expected.

@clue clue added this to the v0.6.1 milestone Feb 13, 2019

@clue clue added the new feature label Feb 13, 2019

@jsor

jsor approved these changes Feb 13, 2019

Improve error reporting when spawning child process fails
Suppress PHP warnings on error and report any error message as part of
exception messages as expected.

@clue clue force-pushed the clue-labs:error-reporting branch from 1e10d48 to 1e61ce4 Feb 15, 2019

@clue

This comment has been minimized.

Copy link
Member Author

clue commented Feb 15, 2019

Updated to skip failing unit test on legacy PHP 5 👍

@WyriHaximus

This comment has been minimized.

Copy link
Member

WyriHaximus commented Feb 15, 2019

@clue cheers 👍

@WyriHaximus WyriHaximus merged commit 1409327 into reactphp:master Feb 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@clue clue deleted the clue-labs:error-reporting branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.