Prefix all global functions calls with \ to skip the look up and resolve process and go straight to the global function #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
reviewed
Oct 3, 2018
src/Factory.php
Outdated
|
|
||
| return $this->resolveAddress($address)->then(function ($address) use ($loop) { | ||
| $socket = @stream_socket_server($address, $errno, $errstr, STREAM_SERVER_BIND); | ||
| $socket = @\stream_socket_server($address, $errno, $errstr, STREAM_SERVER_BIND); |
Member
There was a problem hiding this comment.
Changes LGTM, though the same should probably also be applied to global constants, no? Can you amend the PR accordingly? 👍
Member
Author
There was a problem hiding this comment.
Yes it should I'll amend the PR on the next train 👍
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.