Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward compatibility with upcoming Cache v0.6 and Cache v1.0 #121

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
4 participants
@clue
Copy link
Member

commented Jan 29, 2019

Cache v0.6 is going to be tagged soon: https://github.com/reactphp/cache/milestone/4. This component is already compatible with both the upcoming version as well as legacy versions. The Cache component is pretty much stable already and we plan to not introduce any BC breaks anymore: reactphp/cache#8

Builds on top of #102

@clue clue added this to the v0.4.17 milestone Jan 29, 2019

@WyriHaximus WyriHaximus requested review from WyriHaximus and jsor Jan 29, 2019

@kelunik

This comment has been minimized.

Copy link

commented Jan 29, 2019

What's the reason to do these before the release? I may have already asked this, sorry if that's the case.

@clue

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2019

What's the reason to do these before the release?

Both approaches are workable. We want to ensure that people will be able to install the new cache component ASAP when the new release is out, hence we try to make components that depend on this version compatible before the release.

@jsor

jsor approved these changes Jan 30, 2019

@kelunik

This comment has been minimized.

Copy link

commented Jan 30, 2019

@clue thanks!

@clue clue merged commit d0ef329 into reactphp:master Jan 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@clue clue deleted the clue-labs:cache-compatibility branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.