Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport parsing `authority` and `additional` records from DNS response #123
Conversation
clue
added
the
new feature
label
Jan 30, 2019
clue
added this to the v0.4.17 milestone
Jan 30, 2019
jsor
approved these changes
Jan 30, 2019
WyriHaximus
approved these changes
Jan 30, 2019
WyriHaximus
merged commit 949d6f0
into
reactphp:master
Jan 30, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
clue
deleted the
clue-labs:parse-authority-additional
branch
Jan 30, 2019
clue
referenced this pull request
Jan 30, 2019
Merged
Support dumping records as part of outgoing binary DNS message #124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
clue commentedJan 30, 2019
This PR adds support for parsing
authorityandadditionalrecords from DNS response messages in accordance to RFC 1035. Among others, this is a prerequisite for parsing EDNS0 responses (#100) which is left up to a follow-up PR. This is a pure feature addition (without any BC breaks), though this is not currently used in practice.Resolves #32