Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dumping records as part of outgoing binary DNS message #124

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
3 participants
@clue
Copy link
Member

commented Jan 30, 2019

This PR adds support for sending answer/authority/additional records for DNS response/reply messages in accordance to RFC 1035. This is similar to #123 which adds the receiving side, while this PR adds the sending side. Among others, this is a prerequisite for a possible future DNS server part (#9) or for parsing EDNS0 responses (#100) which is left up to a follow-up PR. This is a pure feature addition (without any BC breaks), though this is not currently used in practice.

Builds on top of #104, #105, #106, #107, #108 and others

@clue clue added the new feature label Jan 30, 2019

@clue clue added this to the v0.4.17 milestone Jan 30, 2019

@jsor

jsor approved these changes Jan 30, 2019

@WyriHaximus WyriHaximus merged commit 61f824d into reactphp:master Jan 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@clue clue deleted the clue-labs:dump-records branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.