Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete all deprecated APIs, use `Query` objects for `Message` questions instead of nested arrays and increase code coverage to 100% #130

Merged
merged 2 commits into from Jul 9, 2019

Conversation

Projects
None yet
3 participants
@clue
Copy link
Member

commented Jul 9, 2019

This changeset removes all APIs already marked as deprecated and changes the $message->questions array to be an array of Query objects instead of nested arrays as already documented. These APIs are somewhat internal and it's very unlikely this will affect many consumers of this package.

Builds on top of #129, #123 and #99
Refs #128

@clue clue added this to the v1.0.0 milestone Jul 9, 2019

@clue clue requested review from jsor and WyriHaximus Jul 9, 2019

@jsor

jsor approved these changes Jul 9, 2019

@WyriHaximus WyriHaximus merged commit 3d636a5 into reactphp:master Jul 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@clue clue deleted the clue-labs:delete-deprecated branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.