Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all classes as final to discourage inheritance #134

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@WyriHaximus
Copy link
Member

@WyriHaximus WyriHaximus commented Jul 11, 2019

Classes should be used via composition rather than extension.
This reduces our API footprint and avoids future BC breaks by avoiding
exposing its internal assumptions.

src/Config/HostsFile.php Outdated Show resolved Hide resolved
src/Config/HostsFile.php Outdated Show resolved Hide resolved
src/Config/HostsFile.php Outdated Show resolved Hide resolved
src/Protocol/BinaryDumper.php Outdated Show resolved Hide resolved
clue
clue approved these changes Jul 11, 2019
jsor
jsor approved these changes Jul 11, 2019
@jsor jsor merged commit f8a443b into reactphp:master Jul 11, 2019
1 check passed
@WyriHaximus WyriHaximus deleted the final branch Jul 11, 2019
WyriHaximus
Copy link
Member

WyriHaximus commented on eae3215 Jul 17, 2019

a) We did, but we simply can't just test all dependants out there, especially when it's not listed on https://packagist.org/packages/react/dns/dependents because react/dns is an indirect dependency.
b) This is a major release which allows for BC breaks.

webdevmatics
Copy link

webdevmatics commented on eae3215 Jul 17, 2019

You have to test code before committing. we are getting this issue beyondcode/laravel-websockets#216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants