Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all Record attributes as required, add documentation vs Query #136

Merged
merged 1 commit into from Jul 11, 2019

Conversation

Projects
None yet
3 participants
@clue
Copy link
Member

commented Jul 11, 2019

This changeset marks all Record attributes as required attributes in its constructor. Additionally, it adds some documentation for Record and Query and the fact that they're not the same. These APIs are somewhat internal and it's very unlikely this will affect many consumers of this package.

Builds on top of #130
Refs #128

@clue clue added this to the v1.0.0 milestone Jul 11, 2019

@WyriHaximus WyriHaximus requested a review from jsor Jul 11, 2019

@jsor

jsor approved these changes Jul 11, 2019

@jsor jsor merged commit 9f38d49 into reactphp:master Jul 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@clue clue deleted the clue-labs:record-ctor branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.