Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API documentation for ExecutorInterface #137

Merged
merged 2 commits into from Jul 11, 2019

Conversation

Projects
None yet
3 participants
@clue
Copy link
Member

commented Jul 11, 2019

This changeset adds documentation for the ExecutorInterface and marks its cancellation logic (#28) as required. Practically, this is only a documentation addition, but theoretically this could be considered a BC break for implementations of this interface that do not currently follow this API definition. These APIs are somewhat internal and it's very unlikely this will affect any consumers of this package.

The changeset builds on top of #135, see only the last commit for changes in this PR. I will rebase this once #135 is in.

Builds on top of #135 and #136
Refs #128

@clue clue added this to the v1.0.0 milestone Jul 11, 2019

@WyriHaximus WyriHaximus requested review from WyriHaximus and jsor Jul 11, 2019

@jsor

jsor approved these changes Jul 11, 2019

@jsor jsor merged commit 808d08c into reactphp:master Jul 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@clue clue deleted the clue-labs:executor-docs branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.