Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support escaping literal dots and special characters in domain names #144

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@clue
Copy link
Member

commented Aug 1, 2019

Among others, this is needed for PTR records for DNS-based service
discovery (DNS-SD) that contain "human friendly" names. The
backslash-escaping allows literal dots in the name (escaped) to be
distinguished from label-separator dots (not escaped).
See https://tools.ietf.org/html/rfc6763#section-4.3

Support escaping literal dots and special characters in domain names
Among others, this is needed for PTR records for DNS-based service
discovery (DNS-SD) that contain "human friendly" names. The
backslash-escaping allows literal dots in the name (escaped) to be
distinguished from label-separator dots (not escaped).
See https://tools.ietf.org/html/rfc6763#section-4.3

@clue clue added the new feature label Aug 1, 2019

@clue clue added this to the v1.2.0 milestone Aug 1, 2019

@clue clue requested review from WyriHaximus and jsor Aug 7, 2019

@jsor
jsor approved these changes Aug 7, 2019

@WyriHaximus WyriHaximus merged commit 40c0bc0 into reactphp:master Aug 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@clue clue deleted the clue-labs:escaped-dots branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.