Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally accept explicit udp:// and tcp:// scheme in Factory #146

Merged
merged 1 commit into from Aug 10, 2019

Conversation

@clue
Copy link
Member

commented Aug 8, 2019

The Factory defaults to creating a UDP-based executor-stack. One can now
explicitly specify the tcp:// URI scheme in order force using the new
TCP-based executor stack. In a follow-up changeset, the default will be
changed to automatic transport protocol detection (#19) and the explicit
choice will mostly exist for rare special cases and debugging purposes.

Builds on top of #145
Refs #19
Refs #5

Optionally accept explicit udp:// and tcp:// scheme in Factory
The Factory defaults to creating a UDP-based executor-stack. One can now
explicitly specify the tcp:// URI scheme in order force using the new
TCP-based executor stack. In a follow-up changeset, the default will be
changed to automatic transport protocol detection and the explicit
choice will mostly exist for rare special cases and debugging purposes.

@clue clue added the new feature label Aug 8, 2019

@clue clue added this to the v1.2.0 milestone Aug 8, 2019

@clue clue requested review from jsor and WyriHaximus Aug 9, 2019

@jsor
jsor approved these changes Aug 9, 2019

@WyriHaximus WyriHaximus merged commit 5d2d2c3 into reactphp:master Aug 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@clue clue deleted the clue-labs:explicit-tcp branch Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.