Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling when sending data to DNS server fails (macOS) #171

Merged
merged 3 commits into from Feb 11, 2021

Conversation

clue
Copy link
Member

@clue clue commented Feb 10, 2021

This changeset improves error handling when sending data to the DNS server fails. This is a quite rare error condition but something that can be reproduced when using faulty DNS server entries on macOS (e.g. beyondcode/expose#25 (comment)).

Together with @SimonFrings, I'm currently in the process of migrating from Travis to GitHub actions and improving our test matrix. We've noticed a similar error in the (upcoming) PR for the socket component on macOS only, so I figured it's a good idea to address this upstream (here) instead.

Builds on top of #170 and reactphp/stream#157

@clue clue added this to the v1.5.0 milestone Feb 10, 2021
@clue
Copy link
Member Author

clue commented Feb 10, 2021

The build currently fails due to another flaky test on macOS, seems to be 3/4 chance of it failing. Looks like it could be related to reactphp/stream#150, but after patching this I still get a 1/3 chance of it failing (https://github.com/clue-labs/dns/runs/1873816008?check_suite_focus=true). I'll look into this again no later than tomorrow :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants