Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Improve compatibility with legacy versions #30

Merged
merged 2 commits into from Nov 21, 2015

Conversation

@clue
Copy link
Member

commented Sep 28, 2015

Because why not… :-)

Now more seriously: This project is a low level lib that is used as a building block for quite a few higher level abstractions on top of it. As such, compatibility (even with significantly outdated versions) is a major concern to me.

Note that I'm not suggesting putting significant amount of work into this. The patch is already here and, personally, I see little harm in supporting this.

Also note that I'm not suggesting we need to keep support indefinitely. Should this ever turn out to be a burden in the future, e.g. because we actually require any new language features or some external lib, then I'm all for dropping support again.

@alcohol

This comment has been minimized.

Copy link

commented Sep 29, 2015

Because you are basically telling users that you condone the use of outdated and no longer supported versions, which sets a bad example and further degrades the general PHP landscape we all have to work in.

@cboden

This comment has been minimized.

Copy link
Member

commented Sep 29, 2015

@alcohol As a member of the composer group I'm sure you understand how hard it is for some people to upgrade beyond 5.3.

This library doesn't have any parts that use new language features so I don't see any harm in increasing the potential user base.

@alcohol

This comment has been minimized.

Copy link

commented Sep 29, 2015

I understand, and I have to accept it, but I don't agree with it. Also, Composer has a large existing user base still running on it. Is that really the same case here? Cause, supporting it to "reach a larger audience" really doesn't seem like the right reason to me. Anyway, just my 2 cents. You can't blame me for trying :-(.

@clue

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2015

@alcohol I think you're raising a very valid point here.

Personally, I wouldn't endorse using legacy versions and encourage everybody to upgrade to supported versions for various reasons (new language features, performance improvements, security support etc.).

Despite this, I don't consider pushing (or condoning) anybody my business.

Being a long time contributor to this project, I do, however, consider helping advance and improve this project to be my business. And unless there's a compelling reason, I don't see why these improvements should only reach a part of our user base, excluding a (reasonable sized) portion of our existing users, stuck on legacy versions.

@WyriHaximus

This comment has been minimized.

Copy link
Member

commented Nov 21, 2015

Tbh I have no objections against this that I didn't already express in the related PR's. Both of you have valid arguments but the changes are to small and insignificant not to do it.

clue added a commit that referenced this pull request Nov 21, 2015
Merge pull request #30 from clue-labs/compat
[RFC] Improve compatibility with legacy versions

@clue clue merged commit ded1ec3 into reactphp:master Nov 21, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@clue clue modified the milestone: v0.4.2 Feb 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.