Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsupported EventConfig and SEGFAULTs on shutdown for ext-event on Windows #205

Merged
merged 3 commits into from Dec 28, 2019

Conversation

@clue
Copy link
Member

clue commented Dec 27, 2019

Resolves #189
Supersedes / closes #192, thanks @inri13666 for the initial version!
Builds on top of #204

@clue clue added the bug label Dec 27, 2019
@clue clue added this to the v1.1.1 milestone Dec 27, 2019
@clue

This comment has been minimized.

Copy link
Member Author

clue commented Dec 27, 2019

The test suite executes just fine and all tests succeed, but it returns a SEGFAULT after running all the tests. I can reproduce the same problem locally, but this does not appear to be related to this changeset.

@jsor
jsor approved these changes Dec 27, 2019
@clue clue changed the title Fix unsupported EventConfig for ext-event on Windows Fix unsupported EventConfig and SEGFAULTs on shutdown for ext-event on Windows Dec 27, 2019
@clue

This comment has been minimized.

Copy link
Member Author

clue commented Dec 27, 2019

I've fixed all SEGFAULTs by clearing all Event references in the destructor. The test suite now works without any issues on Windows :shipit:

@WyriHaximus WyriHaximus merged commit 1d8055f into reactphp:master Dec 28, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@clue clue deleted the clue-labs:ext-event-windows branch Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.