Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing Cookie request header with comma in its values #352

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@fiskie
Copy link
Contributor

fiskie commented Nov 30, 2019

Hello,

I encountered an odd issue with the introduction of some cookie consent tool that was on one of my projects. Currently, any cookie containing a comma will break cookie parsing and add no cookies to the request.

This commit fixes the issue and adds an extra test case against the problem.

@clue clue changed the title Fix handling of multiple cookie headers and comma values Fix parsing Cookie request header with comma in its values Nov 30, 2019
@clue clue added the bug label Nov 30, 2019
@clue clue modified the milestones: v0.9.0, v0.8.6 Nov 30, 2019
@clue
clue approved these changes Nov 30, 2019
Copy link
Member

clue left a comment

@fiskie Thank you for looking into this, changes LGTM! 👍

@WyriHaximus WyriHaximus requested review from WyriHaximus and jsor Nov 30, 2019
Copy link
Member

WyriHaximus left a comment

👍

@jsor
jsor approved these changes Dec 3, 2019
@jsor jsor merged commit 847d2fc into reactphp:master Dec 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.