Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unneeded warning when decoding invalid data on PHP 7.4 #357

merged 1 commit into from Jan 12, 2020


Copy link

WyriHaximus commented Jan 11, 2020

Supersedes / Closes #356
Refs: reactphp/http-client#150

@WyriHaximus WyriHaximus added this to the v0.8.6 milestone Jan 11, 2020
@WyriHaximus WyriHaximus requested review from jsor and clue Jan 11, 2020
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@clue clue added bug easy pick and removed maintenance labels Jan 12, 2020
@WyriHaximus WyriHaximus force-pushed the WyriHaximus-labs:php-7.4 branch from d17df71 to 0561623 Jan 12, 2020
Copy link

clue left a comment

PHPUnit 7+ reports a warning due to unsupported XML definition, otherwise LGTM 👍

.travis.yml Show resolved Hide resolved
@WyriHaximus WyriHaximus force-pushed the WyriHaximus-labs:php-7.4 branch from 0561623 to 3cf9dc0 Jan 12, 2020
@WyriHaximus WyriHaximus requested a review from clue Jan 12, 2020
clue approved these changes Jan 12, 2020
jsor approved these changes Jan 12, 2020
@jsor jsor merged commit 248202e into reactphp:master Jan 12, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.