Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculating concurrency when post_max_size ini is unlimited #365

merged 1 commit into from Jul 4, 2020


Copy link

@clue clue commented Jul 4, 2020

Setting post_max_size to 0 means the HTTP request body size is unlimited. This has a similar effect to setting it to a very large value (e.g. 4G). Accordingly, we have to limit concurrency to not exceed the memory_limit setting (see also #342).

In other words, this is more of an edge case and it's usually not recommended to allow keeping a very large HTTP request body in memory. The post_max_size should be limited to a reasonable value to support decent concurrency.

Resolves #360

@clue clue added the bug label Jul 4, 2020
@clue clue added this to the v0.8.7 milestone Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Division by zero in src/Server.php line 175
3 participants