Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo, a mixed up param name and add forgotten namespace backslash #399

merged 1 commit into from Jan 26, 2021


Copy link

@pavog pavog commented Jan 6, 2021

Hello, I noticed a few minor problems in the browser that I would like to fix with this pr.

I renamed the "$contents" parameter in requestStreaming() to "$body" to match the other functions where it is called "$body".

Copy link

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavog Thanks for looking into this, the suggested changes LGTM! :shipit:

The change refs #401, but I suppose it makes more sense to address this individually 👍

@jsor jsor merged commit 4e4a6b5 into reactphp:master Jan 26, 2021
@pavog pavog deleted the patch-1 branch January 26, 2021 16:48
@clue clue added this to the v1.3.0 milestone Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants