Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support object streams by buffering original write chunks in array #15

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
3 participants
@clue
Copy link
Member

commented Oct 26, 2018

The unwrapWritable() function now buffers all outstanding writes in an array instead of assuming strings. This means it now supports unwrapping streams that expect non-string values (object stream), such as CSV or NDJON encoders.

@clue clue added the new feature label Oct 26, 2018

@clue clue added this to the v1.2.0 milestone Oct 26, 2018

@jsor

jsor approved these changes Oct 26, 2018

@WyriHaximus WyriHaximus merged commit de1ef83 into reactphp:master Oct 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@clue clue deleted the clue-labs:write-chunks branch Oct 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.