Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PHP 8.4+ support by avoiding implicitly nullable types #70

Merged
merged 1 commit into from
May 24, 2024

Conversation

clue
Copy link
Member

@clue clue commented May 22, 2024

This changeset improves PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise.

Marking this as WIP until the upstream components have been released. In the meantime, this may use temporary development branches.

Builds on top of #68, #46 and reactphp/promise#260

@clue clue added this to the v1.11.0 milestone May 22, 2024
@SimonFrings
Copy link
Member

@clue The upstream Promise component has released its new v3.2.0, which means we can continue here as well 👍

@clue clue marked this pull request as ready for review May 24, 2024 12:44
@clue clue changed the title [WIP] Improve PHP 8.4+ support by avoiding implicitly nullable types Improve PHP 8.4+ support by avoiding implicitly nullable types May 24, 2024
@clue
Copy link
Member Author

clue commented May 24, 2024

Updated now that https://github.com/reactphp/promise/releases/tag/v3.2.0 has been released, this is now ready for review :shipit:

Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants