[RFC] Remove branch-alias definitions #343

Closed
clue opened this Issue Feb 29, 2016 · 10 comments

Projects

None yet

4 participants

@clue
Member
clue commented Feb 29, 2016

Most (but not all) of our components use a branch-alias definition for Composer. This ticket aims to serve as a discussion basis whether it actually makes sense to keep these.

IMHO having a branch-alias is a real PITA, as it provides very little value and often ends up getting out of sync with the branch.

As an alternative, I would suggest dropping the definitions and using an inline alias as required:

$ composer require "react/socket-client:dev-master as 0.5.0"
@clue clue referenced this issue in reactphp/socket Feb 29, 2016
Merged

Update documentation #32

@jsor
Member
jsor commented Mar 1, 2016

I always understood branch-alias as requiring a dev-version of an upcoming tag, eg. 0.5.0. If the version 0.5.0 is tagged and the branch-alias is changed to 0.6.0, i still get ~0.5.0 which isn't the case if i'm requiring dev-master. But, i may be wrong... ;)

@clue
Member
clue commented May 3, 2016

I always understood branch-alias as requiring a dev-version of an upcoming tag, eg. 0.5.0.

This is correct, and I see some (but little) use in this.

If the version 0.5.0 is tagged and the branch-alias is changed to 0.6.0 […]

The branch-alias will have to be updated before the first change with a BC break lands. Note that this most likely isn't right after a tag has been set, because there may still be more future patch level releases (like 0.5.x). Because we would regularly have to check whether the branch-alias is still in line the current line of development, I consider this a real PITA.

My main point here is: Maintaining the branch-alias requires continuous effort, but is it really worth it? Is much gained by maintaining this? Should we really endorse depending on development versions?

@jsor
Member
jsor commented May 3, 2016

I'm undecided on this, could live with either decision. Any thoughts by @WyriHaximus or @cboden?

@cboden
Member
cboden commented May 3, 2016

I haven't found it particularly useful when using React in outside projects and it is a PITA to maintain. Unless someone comes up with a compelling argument to keep them I'm +1 for removing them.

@WyriHaximus
Member

Honestly it seems to cause more confusion then it has any benefits at the moment. I'm in favour of removing them 👍

@jsor
Member
jsor commented Jul 6, 2016

👍

@clue
Member
clue commented Jul 6, 2016

Thanks for the feedback, I think we all agree 👍

Does anybody feel like filing a few very simple PRs? :shipit:

@WyriHaximus
Member

Sure I'll get on it tonight 😄

@jsor jsor added a commit to reactphp/promise that referenced this issue Jul 6, 2016
@jsor jsor Remove branch-alias definition as per reactphp/react#343 9b3b010
@WyriHaximus WyriHaximus added a commit to WyriHaximus/stream that referenced this issue Jul 6, 2016
@WyriHaximus WyriHaximus Remove branch-alias definition as per reactphp/react#343 79f002d
@WyriHaximus WyriHaximus added a commit to WyriHaximus/stomp that referenced this issue Jul 6, 2016
@WyriHaximus WyriHaximus Remove branch-alias definition as per reactphp/react#343 0e91e0f
@WyriHaximus WyriHaximus added a commit to WyriHaximus/socket that referenced this issue Jul 6, 2016
@WyriHaximus WyriHaximus Remove branch-alias definition as per reactphp/react#343 8d6bd63
@WyriHaximus WyriHaximus added a commit to WyriHaximus/partial that referenced this issue Jul 6, 2016
@WyriHaximus WyriHaximus Remove branch-alias definition as per reactphp/react#343 f45e98a
@WyriHaximus WyriHaximus added a commit to reactphp/http-client that referenced this issue Jul 6, 2016
@WyriHaximus WyriHaximus Remove branch-alias definition as per reactphp/react#343 fa122e9
@WyriHaximus WyriHaximus added a commit to WyriHaximus/event-loop that referenced this issue Jul 6, 2016
@WyriHaximus WyriHaximus Remove branch-alias definition as per reactphp/react#343 30c6ef5
@WyriHaximus WyriHaximus added a commit to WyriHaximus/child-process that referenced this issue Jul 6, 2016
@WyriHaximus WyriHaximus Remove branch-alias definition as per reactphp/react#343 c4f152e
@WyriHaximus WyriHaximus added a commit to WyriHaximus/whois that referenced this issue Jul 6, 2016
@WyriHaximus WyriHaximus Remove branch-alias definition as per reactphp/react#343 d1708cb
@WyriHaximus
Member

Ok that is all of them I think 😎

@clue clue added a commit to clue-labs/http that referenced this issue Aug 9, 2016
@WyriHaximus @clue WyriHaximus + clue Remove branch-alias definition as per reactphp/react#343 f0000a5
@clue
Member
clue commented Nov 15, 2016

Closed via referenced tickets 👍

@clue clue closed this Nov 15, 2016
@jsor jsor added a commit to reactphp/promise that referenced this issue Dec 22, 2016
@jsor jsor Remove branch-alias definition as per reactphp/react#343 e5f1059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment