Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example 99 improvements #190

Merged
merged 2 commits into from Jan 24, 2019

Conversation

Projects
None yet
3 participants
@jsor
Copy link
Member

commented Jan 22, 2019

Minor fixes and improvements for examples/99-generate-self-signed.php discovered in #189

jsor added some commits Jan 22, 2019

@clue
Copy link
Member

left a comment

Good catch! This repo still has a localhost_swordfish.pem and a number of references to this in the tests, do you think this should be updated as part of this PR? 👍

@jsor

This comment has been minimized.

Copy link
Member Author

commented Jan 24, 2019

@clue Yes, i noticed that as well. But i didn't find any direct references to this script. It's still possible to generate a cert with the password swordfish.

@clue

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

@jsor Good, no objections then 👍

@clue

clue approved these changes Jan 24, 2019

@clue clue merged commit 2cf8dfa into reactphp:master Jan 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@clue clue added this to the v1.2.1 milestone May 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.