Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around failing test case detecting EOF on TLS 1.3 socket streams #201

Merged
merged 1 commit into from May 27, 2019

Conversation

Projects
None yet
3 participants
@clue
Copy link
Member

commented May 26, 2019

This PR improves the test suite to avoid a possible race condition for
our TLS tests. It does not change anything about the actual behavior or
the expected output, but it helps making the expected output more
explicit and no longer subject to a possible race condition. This helps
avoiding possible false negatives if TLS 1.3 is supported and PHP
reports the EOF indicator before consuming all application data.

This builds on top of #185 and #186

Work around failing test case detecting EOF on TLS 1.3 socket streams
This PR improves the test suite to avoid a possible race condition for
our TLS tests. It does not change anything about the actual behavior or
the expected output, but it helps making the expected output more
explicit and no longer subject to a possible race condition. This helps
avoiding possible false negatives if TLS 1.3 is supported and PHP
reports the EOF indicator before consuming all application data.

This builds on top of #185 and
#186

@clue clue added the maintenance label May 26, 2019

@clue clue added this to the v1.2.1 milestone May 26, 2019

@jsor

jsor approved these changes May 27, 2019

@WyriHaximus WyriHaximus merged commit 032db4d into reactphp:master May 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@clue clue deleted the clue-labs:test-race branch May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.