Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Avoid uneeded fragmented TLS work around for PHP 7.3.3+ #202
The work around was introduced in order to bring TLS 1.3 support to all
Reproduction is not exactly trivial unfortunately. Prior to #186, older PHP version would simply consume 100% CPU usage when using an otherwise perfectly valid TLS 1.3 connection when the remote peer did not send any data (common for HTTPS). After applying #186 this bug has been avoided on all supported versions, including older PHP versions. However, at the same time it may cause very large data chunks for high throughput scenarios. In other words, when downloading large files over HTTPS, it would start emitting chunks of data that could be multiple megabytes large which has a significant performance hit. Now that the underlying bug in PHP has been fixed with PHP 7.3.3 and PHP 7.2.15, we do not need this work around from #186 anymore. As such, we now have proper TLS 1.3 support with reasonable data chunks on recent PHP versions and still have a work around for TLS 1.3 on older PHP versions.