Skip to content

Improve test suite by awaiting events instead of sleeping #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

clue
Copy link
Member

@clue clue commented Aug 15, 2019

This changeset improves the test suite by awaiting events instead of sleeping. On my machine, this changes average test execution time from ~8.5s to ~2.7s.

@clue clue added this to the v1.4.0 milestone Aug 15, 2019
@clue
Copy link
Member Author

clue commented Aug 15, 2019

The test failure is unrelated to this PR and is being addressed in #210 individually :shipit:

@clue clue requested a review from WyriHaximus August 16, 2019 08:57
@clue
Copy link
Member Author

clue commented Aug 16, 2019

Rebased now that #210 is in :shipit:

@WyriHaximus WyriHaximus merged commit ccdab00 into reactphp:master Aug 16, 2019
@clue clue deleted the sleepy-tests branch August 16, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants