Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting to include both IPv6 & IPv4 errors (happy eyeballs) #233

merged 2 commits into from May 17, 2020


Copy link

@clue clue commented May 16, 2020

This changeset improves error reporting for failed connection attempts using happy eyeballs to always include the last error message for both IPv6 and IPv4 protocol families. The rationale for this is that both families commonly fail for very different reasons (broken IPv6 connectivity etc.). If both families report the same error, the message will only include a single message:

Connection to foo.invalid failed during DNS lookup: DNS query for foo.invalid returned an error response (Server Failure)

Connection to failed: Last error for IPv4: Given URI "tcp://" is invalid. Previous error for IPv6: DNS query for did not return a valid answer (NOERROR / NODATA)

Builds on top of #232, #231, #230, #224 and #225
Refs #171 and others

@clue clue added this to the v1.5.0 milestone May 16, 2020
@jsor jsor merged commit f5049f0 into reactphp:master May 17, 2020
@clue clue deleted the eyeballs-errors branch May 17, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants