Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove undocumented and now unused ReadableStream and WritableStream #93

merged 1 commit into from Apr 27, 2017


Copy link

@clue clue commented Apr 27, 2017

This simple PR removes the ReadableStream and WritableStream classes. These classes have attracted some very low quality code and they never really followed the stream semantics.

Note that this does not affect the interfaces or resource implementations that most people use.

Empirical evidence suggests this isn't really needed anyway, so I propose to remove it from the public API for now. Should we need this again in the future, it's a simple feature addition with no BC break, so I'd suggest removing this until we find a use case that actually relies on this.

Builds on top of #88

@clue clue added the BC break label Apr 27, 2017
@clue clue added this to the v0.7.0 milestone Apr 27, 2017
@WyriHaximus WyriHaximus requested review from jsor and WyriHaximus Apr 27, 2017
jsor approved these changes Apr 27, 2017
@WyriHaximus WyriHaximus merged commit e65c2b1 into reactphp:master Apr 27, 2017
1 check passed
@clue clue deleted the no-readable-writable branch Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants