Simplify usage by updating to new default loop #54
Conversation
clue
changed the title
|
This is ready for review. I can merge once reviewed and the linked components have been tagged. |
| @@ -53,15 +51,13 @@ $server = new React\Http\Server($loop, function (Psr\Http\Message\ServerRequestI | |||
| ); | |||
| }); | |||
|
|
|||
| $socket = new React\Socket\Server(8080, $loop); | |||
| $socket = new React\Socket\Server('127.0.0.1:8080'); | |||
There was a problem hiding this comment.
Might as well make it listen on all IP's
| $socket = new React\Socket\Server('127.0.0.1:8080'); | |
| $socket = new React\Socket\Server('0.0.0.0:8080'); |
There was a problem hiding this comment.
No strong preference here tbh. My change doesn't change this example at all, as localhost is also the default when only specifying the port, but it's somewhat more obvious this way.
I think recommending localhost listen address as a starting point is a more safe. Exposing this to the public internet requires only slightly more effort, but this is where things start to highly depend on use case / setup anyway, such as reverse proxy etc.. Additionally, the localhost address can also be used as is in URLs, which might make getting started slightly easier. WDYT?
There was a problem hiding this comment.
True, but IMHO we could better educate what values are often used in production. Any machine you startup should have a firewall enabled by default. I agree that it's safer, but we should also guide our users from start to production with our project and these little things help.
WyriHaximus
changed the title
This changeset simplifies usage by updating to use the new default loop.
Builds on top of reactphp/event-loop#226, reactphp/event-loop#232, reactphp/socket#260 and reactphp/http#410