Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): upgrade to bootstrap 4.0.0-beta.3 #758

Merged
merged 3 commits into from Jan 2, 2018
Merged

chore(docs): upgrade to bootstrap 4.0.0-beta.3 #758

merged 3 commits into from Jan 2, 2018

Conversation

supergibbs
Copy link
Collaborator

Also changes col-form-legend to col-form-label in examples

@kraenhansen
Copy link
Contributor

Unfortunately I don't think it's this easy - beta.3 contains breaking changes - ex. the InputGroupButton doesn't work as expected with CSS from bootstrap 4.0.0-beta.3.

Also - "beta.2" is mentioned a couple of places that probably needs updating too.

@supergibbs
Copy link
Collaborator Author

supergibbs commented Jan 2, 2018

You are right, there is more to update than just the package.json file. I updated the docs but the breaking changes will be separate PRs. I've already done #757 and am working on #759; hopefully will have ready later today. This PR should be merged in when others are too.

@TheSharpieOne TheSharpieOne merged commit 93a342b into reactstrap:master Jan 2, 2018
@supergibbs supergibbs deleted the form-legend branch January 2, 2018 21:39
jlaramie pushed a commit to jlaramie/reactstrap that referenced this pull request Jan 18, 2018
* chore(docs): upgrade to bootstrap 4.0.0-beta.3
* Update yarn lock file and a couple of other mentions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants