Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Fix Link header parsing #76

Closed
slorber opened this issue Jan 8, 2014 · 1 comment
Closed

Fix Link header parsing #76

slorber opened this issue Jan 8, 2014 · 1 comment

Comments

@slorber
Copy link
Contributor

slorber commented Jan 8, 2014

Because of a parser bug in banana-rdf there's a bug here too.

The parsing of link headers have been temporarily disabled and must be rewired when the banana bug is fixed:
banana-rdf/banana-rdf#84

  def parseHeaders(base: Rdf#URI, headers: FluentCaseInsensitiveStringsMap): PointedGraph[Rdf] = {
    import collection.convert.wrapAsScala._
    // TODO we temporarily disable parsing of link headers because of a banana link header parsing bug:
    // https://github.com/w3c/banana-rdf/issues/84
    // val linkHeaders = Option(headers.get("Link")).map{_.toList}.getOrElse(Nil)
    val linkHeaders = Nil
    val linkgraph = union(linkHeaders.map(parser.parse(_).resolveAgainst(base)))
    PointedGraph(base, linkgraph)
  }
@ghost ghost assigned bblfish Jan 8, 2014
slorber added a commit that referenced this issue Jan 8, 2014
@bblfish bblfish closed this as completed in 4003f75 Jan 8, 2014
@slorber
Copy link
Contributor Author

slorber commented Jan 8, 2014

We need to remove my hack before closing this:

    // val linkHeaders = Option(headers.get("Link")).map{_.toList}.getOrElse(Nil)
    val linkHeaders = Nil

@slorber slorber reopened this Jan 8, 2014
@ghost ghost assigned slorber Jan 8, 2014
slorber added a commit that referenced this issue Jan 10, 2014
@slorber slorber removed their assignment May 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants