Implement a new TTS navigator #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickael-menu
reviewed
Feb 7, 2023
test-app/src/main/java/org/readium/r2/testapp/utils/LifecycleMedia3SessionService.kt
Outdated
Show resolved
Hide resolved
test-app/src/main/java/org/readium/r2/testapp/utils/LifecycleMedia3SessionService.kt
Outdated
Show resolved
Hide resolved
test-app/src/main/java/org/readium/r2/testapp/reader/tts/TtsControls.kt
Outdated
Show resolved
Hide resolved
test-app/src/main/java/org/readium/r2/testapp/reader/tts/TtsControls.kt
Outdated
Show resolved
Hide resolved
readium/navigator/src/main/java/org/readium/r2/navigator/media3/tts/TtsPlayer.kt
Show resolved
Hide resolved
readium/navigator/src/main/java/org/readium/r2/navigator/media3/tts/TtsPlayer.kt
Show resolved
Hide resolved
.../shared/src/main/java/org/readium/r2/shared/publication/services/content/ContentTokenizer.kt
Show resolved
Hide resolved
test-app/src/main/java/org/readium/r2/testapp/reader/VisualReaderFragment.kt
Show resolved
Hide resolved
test-app/src/main/java/org/readium/r2/testapp/reader/VisualReaderFragment.kt
Outdated
Show resolved
Hide resolved
mickael-menu
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TtsNavigatoris (temporarily) located in the packagenavigator.media3.tts. It ties together aTtsPlayerand aTtsSessionAdapterwhich adapts it to the media3Playerinterface. TheTtsPlayerties together aTtsEngineFacadeand a aTtsContentIterator. The former is a wrapper above aTtsEngine, which implements an interface close to the usual TTS library APIs. The latter is a wrapper aboveContentIteratorwhich basically "makes it" seekable.The former
MediaServiceis (temporarily) split between aMediaServiceand aTtsServicewhose lifecycles are tied to the opening and closing of publications.Some other dumb implementations of the
MediaNavigatorinterface are here for the sake of example and will be removed before merging.