Use startForegroundService() for the MediaService

[mickael-menu]

Fix #92

Solution found in https://stackoverflow.com/a/47654126

[qnga]

I believe you! Any chance there is also something to do in https://github.com/readium/kotlin-toolkit/blob/develop/test-app/src/main/java/org/readium/r2/testapp/MediaService.kt?

[mickael-menu]

@qnga I guess it would be here:

kotlin-toolkit/test-app/src/main/java/org/readium/r2/testapp/Application.kt

Line 85 in 5234c25

startService(intent)

But I don't think using startForegroundService() here would be helpful, because I guess it will prevent the app from being destroyed while in background as it is started on app launch.

Like with the previous audio navigator, the media service should be started only when actually playing an audiobook, and stopped when we're done. It needs to be started as "foreground" for the issue raised in #92 but also this:

You use startForeground(int, Notification) if killing your service would be disruptive to the user, such as if your service is performing background music playback, so the user would notice if their music stopped playing.

https://developer.android.com/reference/android/app/Service#startForeground(int,%20android.app.Notification)

[qnga]

Correct, the service is made foreground only when some audiobook is opened. Let's assume that media2 does all the work correctly until proven otherwise.

[mickael-menu]

Fine by me.

@mrifni Did you have time to test this PR?

[mrifni]

@mickael-menu this seems to work, can we merge it ?