Skip to content

Licenses : Add Accept header on fetch status document request #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Licenses : Add Accept header on fetch status document request #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce6cee7
Add Accept header on fetch status document request
hmoukaideche-vivlio Aug 16, 2022
abb4c58
Merge branch 'develop' into fix/fetch-status-document
mickael-menu Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/LCP/License/License.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ extension License: LCPLicense {
.flatMap {
// We fetch the Status Document again after the HTML interaction is done, in case it changed the
// License.
self.httpClient.fetch(statusURL)
self.httpClient.fetch(HTTPRequest(url: statusURL, headers: ["Accept": MediaType.lcpStatusDocument.string]))
.map { $0.body ?? Data() }
.eraseToAnyError()
}
Expand Down
2 changes: 1 addition & 1 deletion Sources/LCP/License/LicenseValidation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ extension LicenseValidation {
private func fetchStatus(of license: LicenseDocument) throws {
let url = try license.url(for: .status, preferredType: .lcpStatusDocument)
// Short timeout to avoid blocking the License, since the LSD is optional.
httpClient.fetch(HTTPRequest(url: url, timeoutInterval: 5))
httpClient.fetch(HTTPRequest(url: url, headers: ["Accept": MediaType.lcpStatusDocument.string], timeoutInterval: 5))
.map { .retrievedStatusData($0.body ?? Data()) }
.eraseToAnyError()
.resolve(raise)
Expand Down